This repository was archived by the owner on Nov 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Fix Bad state: NoSuchMethodError: The getter 'length' was called on n… #9
Open
fodil-a
wants to merge
3
commits into
stablekernel:master
Choose a base branch
from
fodil-a:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81805bc to
b89920e
Compare
Author
|
also fixes #8 by replacing deprecated calls from analyzer |
sdxv
reviewed
Dec 8, 2020
| final fileUnit = parseFile( | ||
| path: uri.toFilePath(windows: Platform.isWindows), | ||
| featureSet: FeatureSet.fromEnableFlags2( | ||
| flags: [], sdkLanguageVersion: Version(2, 8, 0))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the significance of using version 2.8.0?
sdxv
reviewed
Dec 8, 2020
|
|
||
| dependencies: | ||
| analyzer: '>=0.32.0 <0.50.0' | ||
| analyzer: '>=0.40.6 <0.41.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be more permissive
Suggested change
| analyzer: '>=0.40.6 <0.41.0' | |
| analyzer: '>=0.40.1 <0.42.0' |
sdxv
suggested changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Passes all tests. Never done a code review before, so I hope none of my comments are bad or out of line. The only change I would suggest is the minor tweak to the analyzer versions in pubspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ull.
The issue makes aqueduct db generate crash 100% of the time if you use a version of dart > 2.8.
You need to merge and release a version of isolate-executor and aqueduct ASAP to fix the issue dating from june.